fix: cdk603 error calculating previousLocalExitRoot #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joanestebanr
force-pushed
the
fix/cdk603-previousLER_error-v2
branch
from
96c7e2d to
1d4224c
Compare
joanestebanr
changed the title
|
ToniRamirezM
approved these changes
Nov 27, 2024
vcastellm
reviewed
Nov 27, 2024
| @@ -6,6 +6,7 @@ CREATE TABLE certificate_info ( | |||
| height INTEGER NOT NULL, | |||
| certificate_id VARCHAR NOT NULL PRIMARY KEY, | |||
| status INTEGER NOT NULL, | |||
| previous_local_exit_root VARCHAR , | |||
There was a problem hiding this comment.
Suggested change
| previous_local_exit_root VARCHAR , | |
| previous_local_exit_root VARCHAR, |
vcastellm
reviewed
Nov 27, 2024
vcastellm
reviewed
Nov 27, 2024
|
|
||
| return fmt.Sprintf("Height: %d, CertificateID: %s, NewLocalExitRoot: %s. Status: %s. Errors: [%s]", | ||
| c.Height, c.CertificateID.String(), c.NewLocalExitRoot.String(), c.Status.String(), errors) | ||
| previousLocalExitRoot := "nil" |
There was a problem hiding this comment.
use the nilStr constant?
vcastellm
reviewed
Nov 27, 2024
| @@ -23,6 +23,8 @@ const ( | |||
| Candidate | |||
| InError | |||
| Settled | |||
|
|
|||
| nilStr = "nil" | |||
There was a problem hiding this comment.
Why is this needed, agglayer API?
vcastellm
reviewed
Nov 27, 2024
| @@ -283,7 +285,7 @@ func TestAggSenderStart(t *testing.T) { | |||
| ctx, | |||
| log.WithFields("test", "unittest"), | |||
| Config{ | |||
| StoragePath: "file::memory:?cache=shared", | |||
| StoragePath: "file:TestAggSenderStart?mode=memory&cache=shared", | |||
There was a problem hiding this comment.
Are we 100% sure this is using memory or a file with this name?
vcastellm
reviewed
Nov 27, 2024
Stefan-Ethernal
pushed a commit
that referenced
this pull request
Nov 27, 2024
Support `agglayer:0.2.0-rc.15` the responses of ` CertificateHeader` add a new field: `PreviousLocalExitRoot` - Fixes error calculating previousLocalExitRoot on new certificate if a certificate is inError NOTE: **Database incompatibility with previous version!, require to delete it!**
Vui-Chee
added a commit
to okx/xlayer-cdk
that referenced
this pull request
Dec 3, 2024
* tag 'v0.5.0-beta6': feat: write on database the number of retries per certificate and the certificates in a history table (0xPolygon#208) feat: return an error in case agglayer returns certificate with height lower than in local storage (0xPolygon#209) chore: simplify the `HashMeddler` (0xPolygon#205) fix: clean proof table on start (0xPolygon#207) (0xPolygon#210) feat: improve logs (0xPolygon#204) fix: cdk603 error calculating previousLocalExitRoot (0xPolygon#199) fix: Integration Bali PP (0xPolygon#198) feat: check agglayer certificate and use as initial if db is empty (0xPolygon#192) feat: sqlite aggregator (0xPolygon#189) feat: BridgeMessage e2e test (0xPolygon#184) feat: aggsender e2e (0xPolygon#183) fix: aggregating proofs (0xPolygon#191) (0xPolygon#193) feat: l1infotreesync can be run as individual component (0xPolygon#188) fix: l1infotree flaky test (0xPolygon#182) fix: `L1InfoRootIncorrect` error from `agglayer` (0xPolygon#185) feat: improve aggsender logs (0xPolygon#186) (0xPolygon#187) feat: remove sanity check (0xPolygon#178) (0xPolygon#179) refact: GetSequence method (0xPolygon#169) feat: epoch notifier (0xPolygon#144) feat: unpack and log agglayer errors (0xPolygon#158)
Vui-Chee
added a commit
to okx/xlayer-cdk
that referenced
this pull request
Dec 4, 2024
* dev: (22 commits) fix issues feat: healthcheck (#11) feat: write on database the number of retries per certificate and the certificates in a history table (0xPolygon#208) feat: return an error in case agglayer returns certificate with height lower than in local storage (0xPolygon#209) chore: simplify the `HashMeddler` (0xPolygon#205) fix: clean proof table on start (0xPolygon#207) (0xPolygon#210) feat: improve logs (0xPolygon#204) fix: cdk603 error calculating previousLocalExitRoot (0xPolygon#199) fix: Integration Bali PP (0xPolygon#198) feat: check agglayer certificate and use as initial if db is empty (0xPolygon#192) feat: sqlite aggregator (0xPolygon#189) feat: BridgeMessage e2e test (0xPolygon#184) feat: aggsender e2e (0xPolygon#183) fix: aggregating proofs (0xPolygon#191) (0xPolygon#193) feat: l1infotreesync can be run as individual component (0xPolygon#188) fix: l1infotree flaky test (0xPolygon#182) fix: `L1InfoRootIncorrect` error from `agglayer` (0xPolygon#185) feat: improve aggsender logs (0xPolygon#186) (0xPolygon#187) feat: remove sanity check (0xPolygon#178) (0xPolygon#179) refact: GetSequence method (0xPolygon#169) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Since
agglayer:0.2.0-rc.15the responses ofCertificateHeaderadd a new field:PreviousLocalExitRootNOTE: Database incompatibility with previous version!, require to delete it!